[ZIP 227, ZIP 230] Clarify usage and encoding of issuance validating keys and issuer identifiers#1053
Merged
daira merged 10 commits intozcash:mainfrom Jul 29, 2025
Merged
[ZIP 227, ZIP 230] Clarify usage and encoding of issuance validating keys and issuer identifiers#1053daira merged 10 commits intozcash:mainfrom
daira merged 10 commits intozcash:mainfrom
Conversation
This PR updates the diagram of the relation between the issuance validating key, asset description and asset identifier to correctly describe the changes made in zcash#1042. It also responds to two comments that were added post the merge of that PR.
… to `issuer`, and renaming it to "issuer identifier" (zcash#114) This PR makes the changes mentioned in ZIP 227, ZIP 230, and the relevant image files.
This PR makes the changes requested in zcash#1048.
This PR makes updates to ZIP 246 (aka the V6 SIGHASH algorithm) based on the changes being made as a part of zcash#1048. A minor broken link is also fixed.
* Undo changes to the Issuance Keys specification section concerning `issuer`, and put them in a new `Issuance Identifier` section instead. * Similarly undo changes to `Derivation of issuance validating key` since those are covered by `Issuance Identifier`. * Remove an inapplicable reference `[#protocol-addressesandkeys]` (which describes the spend authority key tree, not the issuance key tree). * Be more precise about the distinction between the encodings of issuance signatures / public keys and their abstract values. This allows the abstract values to be identical to BIP 340 while still supporting algorithm extensibility. * Clarify which consensus rule changes apply only when there is an issuance bundle, and reword a fragile reference to the "sixth rule". Co-authored-by: Jack Grigg <jack@electriccoin.co> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
ZIPs 226 and 227, and other cosmetic changes. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
changed the title
vivek-arte
reviewed
Jul 21, 2025
Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
Co-authored-by: Kris Nuttycombe <kris@nutty.land> Co-authored-by: Jack Grigg <jack@electriccoin.co> Co-authored-by: Arya <aryasolhi@gmail.com> Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
nuttycom
approved these changes
Jul 29, 2025
ConstanceBeguier
added a commit
to QED-it/orchard
that referenced
this pull request
Sep 1, 2025
…es (#182) This PR makes the updates to the encoding of the issuance validating key and the issuance authorization signature, as done in the specification in zcash/zips#1042, along with the further updates in zcash/zips#1048 and zcash/zips#1053. The test vectors are updated in QED-it/zcash-test-vectors#31. --------- Co-authored-by: Constance Beguier <constance@qed-it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1048 with additional changes from the ZIP Editors.
fixes #969